[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

2021-09-01 Thread John McCall via Phabricator via cfe-commits
rjmccall closed this revision. rjmccall added a comment. I agree. This isn't the right approach. The patch in question is currently reverted; if you'd like to argue to not restore it, that conversation should be part of that review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

2021-09-01 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. I just got back from vacation, so am probably missing some of the discussion elsewhere, but I'm a bit skeptical of this patch. It seems it would be confusing for users if clang generates code with different floating-point behaviour depending on how it was built.

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

2021-08-05 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: mibintc, andrew.w.kaylor, rjmccall, zahiraam, hans, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D74436