[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Thank you so much for Alex's review!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc274b1986680: Add implicit map for a list item appears in a reduction clause. (authored by jyu2). Changed prior to commit: https://reviews.llvm.org/D108132?vs=366991=367597#toc Repository: rG LLVM

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366991. jyu2 added a comment. Address Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files: clang/include/clang/Sema/Sema.h

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:19481-19482 if (VD && DSAS->isThreadPrivate(VD)) { + if (NoDiagnose) +continue; DSAStackTy::DSAVarData DVar = DSAS->getTopDSA(VD, /*FromParent=*/false); jyu2 wrote:

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > jyu2 wrote: > > ABataev wrote: > > > `isa`. Also,

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); jyu2 wrote: > ABataev wrote: > > `isa`. Also, what if this is a

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 marked 4 inline comments as not done. jyu2 added a comment. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > `isa`.

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366945. jyu2 edited the summary of this revision. jyu2 added a comment. Address Alex's comments. Thanks Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files:

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); `isa`. Also, what if this is a `MemberExpr`?

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366894. jyu2 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Fix format and add new runtime test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947080 , @jyu2 wrote: >>> I am not sure I can do that. Do you mean when generate map adding coding >>> code to look though reduction clause and generate map for it? > > > >> Yes, exactly. > > We are missing mappable

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. >> I am not sure I can do that. Do you mean when generate map adding coding >> code to look though reduction clause and generate map for it? > Yes, exactly. We are missing mappable checking for example: #pragma omp target parallel for reduction(task, +: b[0:2][2:4][1])

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947053 , @jyu2 wrote: > Hi ABataev, > Thanks for reviedw. > > In D108132#2946927 , @ABataev wrote: > >> Why it can not be performed in codegen? > > I am not sure I can do

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 added a comment. Hi ABataev, Thanks for reviedw. In D108132#2946927 , @ABataev wrote: > Why it can not be performed in codegen? I am not sure I can do that. Do you mean when generate map adding coding code to look though reduction clause and

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Also, would be good to see a runtime test, which reveals the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Why it can not be performed in codegen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. A new rule is added in 5.0: If a list item appears in a reduction, lastprivate or linear clause on a combined