[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

waltl added a comment. In D108243#2995476 , @ahatanak wrote: > Do you need `arc-blocks-avoid-heapify.m`? It seems like the other tests > already cover all the cases we care about. You're right much of it is redundant, but test10a() and test10b() are

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

waltl updated this revision to Diff 372017. waltl added a comment. Delete redundant tests in arc-blocks-avoid-heapify.m. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files:

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

ahatanak added a comment. Do you need `arc-blocks-avoid-heapify.m`? It seems like the other tests already cover all the cases we care about. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

waltl updated this revision to Diff 371467. waltl added a comment. Herald added a subscriber: dang. As suggested, I put the optimization behind an off-by-default flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

ahatanak added a comment. Sorry for the delay in responding. Instead of reverting the commit, can we put this optimization behind an off-by-default flag? As far as we can tell, the only problem we have now that is preventing us to enable this optimization is that clang doesn't copy a block to

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

jyknight added a comment. Ping. Any comment from Apple folks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 ___ cfe-commits mailing list

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

jyknight created this revision. jyknight added reviewers: ahatanak, erik.pilkington, rjmccall. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It has been reverted in Apple's Clang fork for quite some time, possibly ever since it