[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added a comment. This patch has landed as 83f3782c6129e7a5df3faaf0ae576611d16a8d49 but not reflected on Phabricator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108291/n

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam added a comment. In D108291#2980737 , @sylvestre.ledru wrote: > Maybe add this to the release notes of clang 14? @sylvestre.ledru and @aaron.ballman please have a look at D109225 . I have made the suggested ch

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

aaron.ballman added inline comments. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:63 + ErrorOr> BufOrErr = + MemoryBuffer::getFileOrSTDIN(Filename, -1, false); + if (std::error_code EC = BufOrErr.getError()) The `-1` is odd here -- t

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

sylvestre.ledru added a comment. Maybe add this to the release notes of clang 14? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108291/new/ https://reviews.llvm.org/D108291 ___ cfe-commits mailing list c

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Documentation is much improved. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108291/new/ https://reviews.llvm.org/D108291 __

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam marked an inline comment as done. saiislam added a comment. Ping. Any more suggestions/questions? I will update requested changes/documentation for D105191 once this gets through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:19 +/// Such an archive is then passed to this tool to extract cubin files before +/// passing to nvlink. +/// ye-luo wr

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added inline comments. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:19 +/// Such an archive is then passed to this tool to extract cubin files before +/// passing to nvlink. +/// Right now clang-offload-bundler is only used to create

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam updated this revision to Diff 368202. saiislam marked 7 inline comments as done. saiislam added a comment. Herald added a subscriber: sstefan1. 1. Added documentation. 2. Improved error handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

JonChesterfield added a comment. Discussed at the multicompany meeting today. Consensus reached is that the whole-archive/no-whole-archive distinction is unimportant - we can ship a toolchain that has whole-archive semantics and later change the default when doing more work in the linker. It's

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added a comment. this is the working steps in the linking script. clang-offload-bundler (host,device) in: complex_reduction.cpp.o out: complex_reduction-494ba8.o, complex_reduction-5aba63.cubin nvlink (device) in: complex_reduction-5aba63.cubin out: complex_reduction-b1898c.

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam added a comment. In D108291#2951969 , @JonChesterfield wrote: > Tests. The usual bug in this area is that an archive can contain multiple > files with the same name which clobber each other if extracted to the same > directory. It looks to me

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

JonChesterfield added a comment. Tests. The usual bug in this area is that an archive can contain multiple files with the same name which clobber each other if extracted to the same directory. It looks to me like this implementation will fail that test. Also, motivation? Seems this can be worke

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam created this revision. saiislam added reviewers: jdoerfert, ye-luo, grokos, ABataev. Herald added subscribers: mstorsjo, mgorny. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nvlink does not support linking of cubin file