ahatanak added a comment.
AMDGPUAnnotateKernelFeatures::addFeatureAttributes looks for an llvm.trap
instruction and adds attribute "amdgpu-queue-ptr" to the function if it finds
one.
Other than that, it looks like your idea would work too.
Repository:
rL LLVM
It could, but then you'd need to change every front end to have the same
sort of behavior, maybe you want to configure it differently, etc.
That said, I really have no strong opinions here :)
-eric
On Wed, Feb 14, 2018 at 6:51 PM Peter Collingbourne via Phabricator <
revi...@reviews.llvm.org>
pcc added a comment.
Herald added subscribers: llvm-commits, mehdi_amini.
Maybe I'm missing something, but I don't see why we need this attribute.
Couldn't clang have been changed to implement `-ftrap-function` by generating a
call to the trap function instead of emitting an `llvm.trap`
