[PATCH] D108360: [clang][NFC] Remove dead code

2021-08-19 Thread Andy Wingo via Phabricator via cfe-commits
wingo created this revision. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove code that has no effect in SemaType.cpp:processTypeAttrs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108360 Files: clang/li

[PATCH] D108360: [clang][NFC] Remove dead code

2021-08-19 Thread Andy Wingo via Phabricator via cfe-commits
wingo added a reviewer: rjmccall. wingo added a comment. Hi John, I am new to clang, having mostly worked on the WebAssembly target in llvm proper. I have a stack of patches related to address space treatment in codegen -- most of them NFC refactors to later allow the WebAssembly target to all

[PATCH] D108360: [clang][NFC] Remove dead code

2021-08-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a reviewer: Anastasia. rjmccall added a comment. Hi, Andy. This patch is obviously okay, although it makes me wonder if it was introduced by a patch collision or something similar that needs closer attention. CC'ing Anastasia. I'm not sure that I agree with your overall plan, t

[PATCH] D108360: [clang][NFC] Remove dead code

2021-08-23 Thread Andy Wingo via Phabricator via cfe-commits
wingo added a subscriber: tlively. wingo added a comment. Thanks for feedback! Following up on general question in D108464 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108

[PATCH] D108360: [clang][NFC] Remove dead code

2021-08-24 Thread Andy Wingo via Phabricator via cfe-commits
wingo added a comment. @Anastasia is this good to go for you or does this need closer attention? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108360 ___ cfe-commits

[PATCH] D108360: [clang][NFC] Remove dead code

2021-09-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D108360#2962010 , @wingo wrote: > @Anastasia is this good to go for you or does this need closer attention? Yeah I agree that this code seems like a left-over from some refactoring as it seems to have no effect. Repositor

[PATCH] D108360: [clang][NFC] Remove dead code

2021-09-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108360

[PATCH] D108360: [clang][NFC] Remove dead code

2021-09-20 Thread Andy Wingo via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3af1e77341: [clang][NFC] Remove dead code (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.