[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki abandoned this revision. linjamaki added a comment. D109818 includes the change in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D108367

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

pekka.jaaskelainen added a comment. In D108367#2966746 , @pekka.jaaskelainen wrote: > @Anastasia I used to have svn commit access, but haven't committed anything > for a long while in LLVM, so don't know if I can get them back to github by > just aski

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

pekka.jaaskelainen added a comment. @Anastasia I used to have svn commit access, but haven't committed anything for a long while in LLVM, so don't know if I can get them back to github by just asking. So, can you please commit these HIPSPV patches for us? Repository: rG LLVM Github Monorepo

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki added a comment. Thanks for the review. In an upcoming HIPSPV patch there will be a test that depends on this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D108367 ___

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Do you think we can test this somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki created this revision. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make computeSPIRKernelABIInfo() to use SPIRABIInfo instead of DefaultABIInfo. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1083