[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf387a3617860: [NFC][clang] Move remaining part of X86Target.def to… (authored by a.elovikov). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a comment. In D108422#2958761 , @lebedev.ri wrote: > This should be autogenerated from the main `X86.td`, otherwise this is, > unfortunately only partially, duplicates that. > E.g. there isn't a single AMD CPU in there. The intent of t

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

lebedev.ri added a comment. This should be autogenerated from the main `X86.td`, otherwise this is, unfortunately only partially, duplicates that. E.g. there isn't a single AMD CPU in there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

LuoYuanke added a comment. >> Thanks for reminding. We've supported -march=${CPU}, but forgot to update >> this table. We will update it. > > Shall we get this patch committed first before making any changes? Yes, committing the patch first looks good to me. Repository: rG LLVM Github Monore

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. In D108422#2958591 , @LuoYuanke wrote: > In D108422#2957541 , @erichkeane > wrote: > >> In D108422#2957528 , @RKSimon >> wrote: >> >>> There's n

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

LuoYuanke added a comment. In D108422#2957541 , @erichkeane wrote: > In D108422#2957528 , @RKSimon wrote: > >> There's nothing later than CannonLake here - does Intel need to at least >> reference up to Tiger/Ro

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

a.elovikov updated this revision to Diff 367821. a.elovikov added a comment. Remove stale FIXME comment in the code being moved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 Files: clang/include/clang

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") a.elovikov wrote: > craig.topper wrote: > > erichke

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

a.elovikov added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") craig.topper wrote: > erichkeane wrote: > > RKSimon

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a subscriber: LuoYuanke. erichkeane added a comment. In D108422#2957528 , @RKSimon wrote: > There's nothing later than CannonLake here - does Intel need to at least > reference up to Tiger/Rocketlake? @LuoYuanke ^^ Repository: rG LL

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. There's nothing later than CannonLake here - does Intel need to at least reference up to Tiger/Rocketlake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 ___

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

craig.topper added a comment. I'm not opposed either. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") erichkeane wrote: > RKSimon w

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") RKSimon wrote: > what commented out features? So th

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") what commented out features? Repository: rG LLVM G

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a comment. I'm unopposed here. Craig, what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 ___ cfe-commits mailing list cfe-comm

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

a.elovikov created this revision. a.elovikov added reviewers: erichkeane, craig.topper. a.elovikov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108422 Fi