woodruffw created this revision.
woodruffw added reviewers: klimek, rsmith.
woodruffw added a project: clang.
woodruffw requested review of this revision.
Herald added a subscriber: cfe-commits.
Without this, the combination of `-ast-dump=json` and `-ast-dump-filter FILTER`
produces invalid JSON:
woodruffw updated this revision to Diff 367938.
woodruffw added a comment.
Updated the AST dump tests for JSON to refute the presence of the `Dumping `
prefix.
Also, updated the `gen_ast_dump_json_test.py` generator to work with Python 3
and to behave better without the presence of the `Dumping
woodruffw added a comment.
Another gentle ping for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441/new/
https://reviews.llvm.org/D108441
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The changes LGTM, though I'm not an expert in python.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441/new/
https://reviews.ll
xgupta added a comment.
@woodruffw Please rebase the patch. clang/test/AST/ast-dump-if-json.cpp
testcase is not applying cleanly. If you don't commit access, I can commit on
your behalf. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441
woodruffw updated this revision to Diff 378476.
woodruffw added a comment.
Resolve conflicts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441/new/
https://reviews.llvm.org/D108441
Files:
clang/lib/Frontend/ASTConsumers.cpp
clang/test/AST/
This revision was automatically updated to reflect the committed changes.
Closed by commit rG451d0596d706: [clang] Fix JSON AST output when a filter is
used (authored by woodruffw, committed by xgupta).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
woodruffw added a comment.
Gentle ping for review on this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441/new/
https://reviews.llvm.org/D108441
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
woodruffw added a comment.
Another gentle ping for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441/new/
https://reviews.llvm.org/D108441
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
woodruffw updated this revision to Diff 372595.
woodruffw added a comment.
Increase the context for the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108441/new/
https://reviews.llvm.org/D108441
Files:
clang/lib/Frontend/ASTConsumers.cpp
10 matches
Mail list logo