This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5880c835bdbe: [Sema] Avoid crash in CheckEnumConstant with
contains-error expressions (authored by sammccall).
Repository:
rG LLVM Github Monorepo
sammccall added a comment.
Thanks, and sorry for sitting on this so long.
Addressed comments. I think the failing windows bots were implicit
`-fms-extensions` or so that sometimes makes diagnosis more lazy. Moving the
test to recovery-expr-type.cpp should take care of this as that test case
sp
sammccall updated this revision to Diff 384084.
sammccall marked 3 inline comments as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108451/new/
https://reviews.llvm.org/D108451
Files:
clang/lib/S
aaron.ballman added inline comments.
Comment at: clang/test/Sema/enum.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+
hokein wrote:
> I'd put the test case in `clang/test/SemaCXX/recovery-expr-type.cpp`
+1 -- Sema is for Cish things and SemaCXX is for C++ish
guopeilin added a comment.
Hi, @sammccall thanks for the patch.
The precommit checks suggest that some test cases failing, could you please fix
them. Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108451/new/
https://reviews.llvm.org/D108451
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: clang/lib/Sema/SemaDecl.cpp:17752
+if (Enum->isDependentType() || Val->isTypeDependent() ||
+Val->containsErrors())
EltTy = Context.Dep
sammccall created this revision.
sammccall added reviewers: hokein, guopeilin.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://bugs.llvm.org/show_bug.cgi?id=51554
Repository:
rG LLVM Github Monorepo
https://revi
