[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a subscriber: sbc100. wingo added a comment. Thanks again John & Thomas for your thoughts. In D108464#2961595 , @rjmccall wrote: > In D108464#2960791 , @tlively wrote: > >> I don't think it makes sens

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

rjmccall added a comment. In D108464#2960791 , @tlively wrote: > In D108464#2960623 , @rjmccall > wrote: > >> + JF, who knows something about Web Assembly, or can at least drag in the >> right people >> >> In D1

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

tlively added a comment. In D108464#2960623 , @rjmccall wrote: > + JF, who knows something about Web Assembly, or can at least drag in the > right people > > In D108464#2959591 , @wingo wrote: > >> In D108464#295

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

rjmccall added a reviewer: jfb. rjmccall added a comment. + JF, who knows something about Web Assembly, or can at least drag in the right people In D108464#2959591 , @wingo wrote: > In D108464#2957276 , @wingo w

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo updated this revision to Diff 368098. wingo added a comment. Rebase to no longer require Address default constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108464/new/ https://reviews.llvm.org/D108464 Files: clang/lib/CodeGen/CGBui

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a subscriber: tlively. wingo added a comment. In D108464#2957276 , @wingo wrote: > So... besides the refactor, this is getting closer to where I'm going in > https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still >

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:115 - /// Emit a load from an i1 flag variable. - llvm::LoadInst *CreateFlagLoad(llvm::Value *Addr, it's the change to always return an `Address` from `CreateTempAlloca` that makes these

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo added a comment. So... besides the refactor, this is getting closer to where I'm going in https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still NFC. I think you can see where I would replace `getASTAllocaAddressSpace` with `getAllocaAddressSpace(QualType Ty)`,

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

wingo created this revision. wingo added a reviewer: rjmccall. Herald added subscribers: lxfind, sunfish, dschuff. wingo requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added a project: clang. It used to be tha