[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2982bd9e9b58: [clangd] Use the active file's language for hover code blocks (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 370590. dgoldman added a comment. Remove unnecessary build flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cpp clang-t

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:968 +// fixed one to make sure tests passes on different platform. +TU.ExtraArgs.push_

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 368395. dgoldman added a comment. Simplify setting the definition language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cp

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. In D108584#2962271 , @sammccall wrote: >> Likely will send a follow up diff to include more context in the Objective-C >> decl printing so they highlight properly. > > This might make sense if it provides useful context to human

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

sammccall added a comment. > Likely will send a follow up diff to include more context in the Objective-C > decl printing so they highlight properly. This might make sense if it provides useful context to human readers without too much syntactic weight. However if the issue is that particular e

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

kadircet added a comment. thanks, mostly looks good. any reason for not doing it centrally though ? Comment at: clang-tools-extra/clangd/Hover.cpp:1024 HI->SymRange = halfOpenToRange(SM, HighlightRange); return HI; can we set it once around here instead

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. LMK if you can think of a better approach to decide which language to use here. Likely will send a follow up diff to include more context in the Objective-C decl printing so they highlight properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This helps improve the