[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by default after this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 _

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

aaron.ballman added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? Can you give a bit more details about what you're seeing? "not set at all" sounds

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? @glandium would you mind giving a reproducer. We might have missed a flow path where t

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. In D109239#3454084 , @zahiraam wrote: > In D109239#3453770 , @glandium > wrote: > >> Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by >> default after this change?

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. The updates in `clang/test/Preprocessor` kind of suggest this was an expected change, though... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

ArcsinX added a comment. It seems for x86_32 case (e.g. with -m32 in command line) there is a difference between clang and GCC: clang: `__FLT_EVAL_METHOD__` == 0 GCC: `__FLT_EVAL_METHOD__` == 2 Example: https://godbolt.org/z/EbY8rPYGn I am not sure, is it a correct behavior from clang? CHANGE

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3878422 , @ArcsinX wrote: > It seems for x86_32 case (e.g. with -m32 in command line) there is a > difference between clang and GCC: > clang: `__FLT_EVAL_METHOD__` == 0 > GCC: `__FLT_EVAL_METHOD__` == 2 > > Example: >

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. Looks like the lists weren't subscribed for the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commi

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. > Oh, I added a NFC fix previously in > https://github.com/llvm/llvm-project/commit/25cdf87b13eb990eb84d31211280f4b0d5d470b3. > I think it should be reverted too? I am going to revert it. I did that in 5d110ed4cd4

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 409307. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. @thakis, @ChuanqiXu I have fixed the warning and added a group to it. Can you please review? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailin

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Any idea what's going on in that Modules/cxx20-export-import.cpp failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3326874 , @thakis wrote: > Any idea what's going on in that Modules/cxx20-export-import.cpp failure? I don't see this failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 409349. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3326874 , @thakis wrote: > Any idea what's going on in that Modules/cxx20-export-import.cpp failure? @thakis I wasn't able to reproduce the issue with Modules/cxx20-export-import.cpp locally (tried a couple of build

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Sure, sounds good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. I saw that test failing again. I could repro the problem locally and fixed it in 1689b1092ebb2c630f8ef1d3880a9fb4808d16fa . I guess this did make it into the pch somehow after all. But all good now. R

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis closed this revision. thakis added a comment. If you put "Differential Revision: https://reviews.llvm.org/D109239"; instead of just "https://reviews.llvm.org/D109239"; in the commit message, phabricator will auto-close the review when the commit lands. Repository: rG LLVM Github Monor

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. It looks like this patch changed the value of `__FLT_EVAL_METHOD__` when building on macOS for some configurations. This is causing build failures when using macOS 10.15's `math.h` and that is breaking most builds on GreenDragon, e.g. : https://green.lab.llvm.org/green/j

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Thank you for reverting my follow-up as well! zahiraam, for the reland please include that follow-up fix in your commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3331914 , @thakis wrote: > Thank you for reverting my follow-up as well! > > zahiraam, for the reland please include that follow-up fix in your commit :) Yes. Will do that. Thanks. Repository: rG LLVM Github Monor

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

jdoerfert added a comment. FWIW, https://github.com/llvm/llvm-project/issues/53931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3332521 , @jdoerfert wrote: > FWIW, https://github.com/llvm/llvm-project/issues/53931 Yes. Working on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/n

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410597. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410803. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410809. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410815. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a subscriber: jonpa. zahiraam added a comment. @jonpa I have added the fix here for https://github.com/llvm/llvm-project/issues/53931 This should work now after I commit this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 __

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 410842. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. @fhahn I think the last commit fixes the issue. I am currently testing it on MacOS 10.14 and it is still going (slow remote machine). I would like to get your permission to push this patch now. It will probably be faster to confirm that the patch fixes the issue runni

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. In D109239#3331917 , @zahiraam wrote: > In D109239#3331914 , @thakis wrote: > >> Thank you for reverting my follow-up as well! >> >> zahiraam, for the reland please include that follow-up f

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Actually, I did it myself in 34285bcd5ac260246c9d59708a63ea3d5972f75c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3341696 , @thakis wrote: > Actually, I did it myself in 34285bcd5ac260246c9d59708a63ea3d5972f75c > @thakis Thanks! CHANGES SINCE LAST ACTION h

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

fhahn added a comment. In D109239#3340872 , @zahiraam wrote: > @fhahn I think the last commit fixes the issue. I am currently testing it on > MacOS 10.14 and it is still going (slow remote machine). I would like to get > your permission to push this pa

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3344107 , @fhahn wrote: > In D109239#3340872 , @zahiraam > wrote: > >> @fhahn I think the last commit fixes the issue. I am currently testing it on >> MacOS 10.14 and it is

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

dmgreen added a comment. Hi. I created this issue about the use of Ofast and -1: https://github.com/llvm/llvm-project/issues/60781 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mail

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#4129733 , @dmgreen wrote: > Hi. I created this issue about the use of Ofast and -1: > https://github.com/llvm/llvm-project/issues/60781 Thanks. Will take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/