[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 389520. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones added a comment. In D109372#3099969 , @jrtc27 wrote: > In D109372#3099947 , @edward-jones > wrote: > >> I reverted some of the previous changes I made so that this patch matches >> the spec as curre

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added a comment. There are still unhandled comments in the patch, btw. Comment at: clang/include/clang/Basic/Attr.td:1797 +def RISCVOverlayCall : InheritableAttr { + let Spellings = [GCC<"overlaycall">]; + let Subjects = SubjectList<[Function]>;

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. In D109372#3099947 , @edward-jones wrote: > I reverted some of the previous changes I made so that this patch matches the > spec as currently written - this means it's two attributes again, and the > diagnostic messages have bee

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones added a comment. Herald added subscribers: VincentWu, luke957. I reverted some of the previous changes I made so that this patch matches the spec as currently written - this means it's two attributes again, and the diagnostic messages have been updated a bit too. The two Clang attri

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 380347. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 374609. edward-jones added a comment. Herald added a subscriber: achieveartificialintelligence. Changes here: - Merged the separate attributes overlaycall and overlaydata into a single overlay attribute (though I may need to undo this to match the hig

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

the_o added a comment. In D109372#2989299 , @edward-jones wrote: > In D109372#2987411 , @jrtc27 wrote: > >> In D109372#2987405 , @MaskRay >> wrote: >> >>> The name "over

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1796 +// trigger an error. +def RISCVOverlayCall : InheritableAttr { + let Spellings = [GCC<"overlaycall">]; jrtc27 wrote: > aaron.ballman wrote: > > edward-jones wrote: > > > jrt

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1796 +// trigger an error. +def RISCVOverlayCall : InheritableAttr { + let Spellings = [GCC<"overlaycall">]; aaron.ballman wrote: > edward-jones wrote: > > jrtc27 wrote: > > > If you wan

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1793-1795 +// This is not marked as a TargetSpecificAttr because that would trigger +// an 'attribute ignored' warning, but we want to check it explicitly and +// trigger an error.

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones added a comment. In D109372#2987411 , @jrtc27 wrote: > In D109372#2987405 , @MaskRay wrote: > >> The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and >> overlayfs, I am thinking

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1793-1795 +// This is not marked as a TargetSpecificAttr because that would trigger +// an 'attribute ignored' warning, but we want to check it explicitly and +// trigger an error.

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. In D109372#2987405 , @MaskRay wrote: > The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and > overlayfs, I am thinking whether this has anything to do with `OVERLAY` > description in a linker script: > http

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

MaskRay added a comment. The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and overlayfs, I am thinking whether this has anything to do with `OVERLAY` description in a linker script: https://sourceware.org/binutils/docs/ld/Overlay-Description.html#Overlay-Description > whi

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added a comment. I don't see anything giving an error if you try and use the new badly-named option for an architecture other than RISC-V (beyond the usual unused argument warning that's only an error with -Werror)? Comment at: clang/include/clang/Basic/Attr.td:348 +//

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones created this revision. Herald added subscribers: vkmr, frasercrmck, dexonsmith, dang, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, simoncook, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-cheng,