[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

2021-09-09 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added a reviewer: jansvoboda11. Herald added a subscriber: dang. c-rhodes requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Identified in D109359 . Repository:

[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

2021-09-09 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. @jansvoboda11 this came up in D109359 with warning: llvm/include/llvm/Option/OptParser.td:217:91: warning: unused template argument: MarshallingInfoBooleanFlag:name I see you've changed worked on this in the past, wasn't sure if it

[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

2021-09-09 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. To give more background, I think my intention was to add an assertion that `name` and `other_name` are the same (except for the `no_` part) and I was waiting for TableGen as

[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

2021-09-09 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. In D109489#2991261 , @jansvoboda11 wrote: > LGTM. > > To give more background, I think my intention was to add an assertion that > `name` and `other_name` are the same (except for the `no_` part) and I was > waiting for TableG

[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

2021-09-09 Thread Cullen Rhodes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8ff4032e2b: [OptParser] NFC: Remove unused template arg 'name' from bool opt (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109489/n