MaskRay added a subscriber: joerg.
MaskRay added a comment.
Thanks for taking over the patch!
I've CCed (in
https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606/33)
some folks who had strong opinions in the initial support patch.
(Cc @joerg manually whom
MaskRay added inline comments.
Comment at: clang/docs/UsersManual.rst:878
Another way to specify a configuration file is to encode it in executable name.
For example, if the Clang executable is named `armv7l-clang` (it may be a
+symbolic link to `clang`), then Clang will
mgorny planned changes to this revision.
mgorny added a reviewer: MaskRay.
mgorny added a comment.
Herald added a subscriber: StephenFan.
So far my plan is to go for `default-{ModeSuffix}.cfg` instead (e.g.
`default-clang.cfg`, `default-clang++.cfg`, etc.). If I'm not mistaken, this
will
mgorny commandeered this revision.
mgorny added a reviewer: asymptotically.
mgorny added a comment.
After discussing privately with @asymptotically, I'm going to try to finish
this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109621/new/
https://reviews.llvm.org/D109621
mstorsjo added a comment.
On this topic, it would be great if we could pick up a per-target default
config file too, if clang is invoked with `clang -target `. Currently
this is done automatically if clang is invoked as `-clang`, but not
with an explicit `-target` parameter.
CHANGES SINCE
mgorny added a comment.
As @sepavloff points out in the linked discussion, we probably need an option
to disable loading default configuration files too, and we should use it in the
test suite (via modifying the `%clang` substitutions, I guess), as otherwise
someone enabling config file
tstellar added a comment.
I similar RFC for this was proposed here:
https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109621/new/
https://reviews.llvm.org/D109621
asymptotically updated this revision to Diff 438106.
asymptotically added a comment.
Herald added a subscriber: MaskRay.
Herald added a project: All.
Updated users' manual following Arfrever's feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109621/new/
Arfrever added inline comments.
Comment at: clang/docs/UsersManual.rst:877
For example, if the Clang executable is named `armv7l-clang` (it may be a
symbolic link to `clang`), then Clang will search for file `armv7l.cfg` in the
+directories mentioned above. If the executable
asymptotically created this revision.
asymptotically added reviewers: rsmith, sepavloff.
asymptotically added a project: clang.
asymptotically requested review of this revision.
Herald added a subscriber: cfe-commits.
If a configuration file is not supplied (either via the driver name or through
10 matches
Mail list logo
