xgupta added a comment.
Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit
message. Though if you spend some time on Phabricator, you will be aware of
which kind of patches need reviews and which can be committed directly.
Repository:
rG LLVM Github Monorepo
CHANGES SI
LittleFox94 added a comment.
This is committed by now, but I would still love to know if this would have
been ok to just commit (and have post-commit review) :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109653/new/
https://reviews.llvm.org/D10
This revision was automatically updated to reflect the committed changes.
Closed by commit rG339c73404224: [Clang][AVR] Fix definitions on AVR target
(authored by LittleFox94).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109653/new/
https://review
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
Thanks!
ref - https://www.microchip.com/en-us/product/ATxmega16A4U
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109653/new/
https://reviews.ll
LittleFox94 added a comment.
I guess this would have qualified for post-commit review, but since this would
have been my first commit I made myself, I want to be careful ^^
Comments on this would be nice, if this would have been ok to just commit.
Repository:
rG LLVM Github Monorepo
CHANGES
LittleFox94 created this revision.
LittleFox94 added a reviewer: cfe-commits.
Herald added subscribers: Jim, dylanmckay.
LittleFox94 requested review of this revision.
Herald added a project: clang.
Fix definitions in AVR target for MCUs xmega16a4u and xmega128a4u to match
avr-libc.
Repository:
