[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9912fe4eac9: [PowerPC] Add range checks for P10 Vector Builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374563. quinnp added a comment. Word change. valid -> expected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/Se

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374561. quinnp added a comment. Added a comment to the out-of-range argument test case to describe the behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 File

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

amyk accepted this revision as: amyk. amyk added a comment. LGTM as long as Lei's comment is addressed. Thanks Quinn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 __

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Please add comment to tc upon commit. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1417 +vector signed int test_vec_vec_splati_ins_range(void) { + // CHE

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374000. quinnp added a comment. Adding a testcase where the second parameter of vec_splati_ins is out of the range 0,1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1414 // CHECK-LE: ret <4 x float> return vec_splati_ins(vfa, 0, 1.0f); } Need to add a testcase where param `b` to `vec_splati_ins(a,b,c)` is not 0 or 1. Repository: rG

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372541. quinnp added a comment. Removing an extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/SemaChec

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372479. quinnp added a comment. Fixing failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/SemaChe

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

amyk added a comment. `builtins-ppc-p10vector.c` looks like it needs to be updated from the failing test case. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1373 vector signed int test_vec_vec_splati_ins_si(void) { + // CHECK-BE: [[T0:%.+]]] = and %{{.+}}, i32 1

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins and changes the signature of a built