[PATCH] D109841: Fix vtbl field addr space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabe8b354e37d: Fix vtbl field addr space (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D109841: Fix vtbl field addr space

rjmccall accepted this revision. rjmccall added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D109841: Fix vtbl field addr space

yaxunl updated this revision to Diff 372792. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: jrtc27. fix comments and casts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 Files: clang/lib/CodeG

[PATCH] D109841: Fix vtbl field addr space

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D109841#3002404 , @arichardson wrote: > Thanks, I can confirm that this fixes the assertions we were seeing after > merging D103835 . A few minor sugge

[PATCH] D109841: Fix vtbl field addr space

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the assertions we were seeing after merging D103835 . A few minor suggestions below: There's a typo in the co

[PATCH] D109841: Fix vtbl field addr space

rjmccall added a comment. The following line is always just making a bitcast, then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D109841: Fix vtbl field addr space

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arichardson. yaxunl requested review of this revision. vtbl filed of an object should have same addr space of the object. Currently it is assumed to be addr space 0 but this may not be true. This caused issue for some out of tree