[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c (authored by ormris). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/n

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___ cfe-commits mailing list cfe-comm

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. I think the test fix is all that's needed for now. This is somewhat urgent for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris updated this revision to Diff 372839. ormris added a comment. - Downgrade to C11 and C++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 Files: clang/test/Lexer/char-escapes-delimited.c Index

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Okay, what's happening is that utf literals are only available for c++11 onward and the tests do not account for that. Would you mind dropping the minimum version to C++11 and C11? I think that would be reasonable. I could do a more extensive fix but I don't know how u

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. We saw this failure for our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow. Repository: rG LLVM Github Mo

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Thanks! For which platforms did you had issue? This is suppose to work in all language modes (we might want to use C99/C++98 to make sure that's the case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https:/

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris created this revision. ormris added reviewers: cor3ntin, aaron.ballman. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify the C and C++ standards explicitly for this test. This avoids failures for drivers that default t