[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32b994bca666: [OpenCL] Defines helper function for OpenCL default address space (authored by Topotuna). Changed prior to commit: https://reviews.l

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Feel free to adjust the naming scheme either in the same commit or separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109874/new/ https://reviews.llvm.org/D

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Anastasia added a comment. In D109874#3011792 , @Topotuna wrote: > Both comments addressed. Personally, I would shuffle words around to rename > helper function as `getDefaultOpenCLPointeeAddrSpace` or > `getOpenCLDefaultPointeeAddrSpace`. Although I am

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna marked 2 inline comments as done. Topotuna added a comment. Both comments addressed. Personally, I would shuffle words around to rename helper function as `getDefaultOpenCLPointeeAddrSpace` or `getOpenCLDefaultPointeeAddrSpace`. Although I am not sure if there are some assumed naming c

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna updated this revision to Diff 373834. Topotuna edited the summary of this revision. Topotuna added a comment. Helper function renamed for clarity. Additional check added to `if` statement to ensure it is only carried out in OpenCL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Anastasia added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1366 + /// Returns default address space based on OpenCL version and enabled features + inline LangAS getDefaultOpenCLAddrSpace() { +return LangOpts.OpenCLGenericAddressSpace ? LangAS::opencl

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna updated this revision to Diff 372937. Topotuna edited the summary of this revision. Topotuna added reviewers: olestrohm, Anastasia. Topotuna added a comment. Code refactored inside `clang/lib/AST/Expr.cpp`. Commit message added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1098

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna planned changes to this revision. Topotuna added a comment. Current change is an initial draft. More code refactoring will be performed and change summary provided in near future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109874/new/

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109874 Files: clang/include/cl