[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Thanks... https://github.com/llvm/llvm-project/commit/7890afddecff01119f4d5e8825b43dd2c8361648 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110083/new/ https://reviews.llvm.org/D110083

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-23 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. In D110083#3019010 , @MyDeveloperDay wrote: > Do you mind if I fix the build failures by encasing the codelike section in a > .. code::? > > diff --git a/clang/docs/ClangOffloadBundler.rst > b/clang/docs/ClangOffloadBundler.

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-23 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Do you mind if I fix the build failures by encasing the codelike section in a .. code::? diff --git a/clang/docs/ClangOffloadBundler.rst b/clang/docs/ClangOffloadBundler.rst index 312c45602c99..ac4c5b51904f 100644 --- a/clang/docs/ClangOffloadBundler.rst

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-21 Thread Saiyedul Islam via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. saiislam marked an inline comment as done. Closed by commit rGee31ad0ab5f7: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation (authored by saiisla

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110083/new/ https://reviews.llvm.org/D110083 __

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-20 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:296 + * Their target triple are the same + * Their GPUArch are the same yaxunl wrote: > This does not match our final view of compatibility

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:296 + * Their target triple are the same + * Their GPUArch are the same This does not match our final view of compatibility. Is this intentional? Thanks. Repository: rG LLVM Githu

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-20 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam created this revision. saiislam added reviewers: yaxunl, jdoerfert, grokos. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add documentation of unbundling of heterogeneous device archives to create device specific archive