[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-22 Thread Thomas Lively via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1552179ac019: [WebAssembly] Add relaxed-simd feature (authored by ngzhian, committed by tlively). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-22 Thread Thomas Lively via Phabricator via cfe-commits
tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Great, thanks! I will take care of landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111 _

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-22 Thread Ng Zhi An via Phabricator via cfe-commits
ngzhian updated this revision to Diff 374262. ngzhian marked an inline comment as done. ngzhian added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Fix fallthrough, add feature to WebAssembly subtarget Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-22 Thread Ng Zhi An via Phabricator via cfe-commits
ngzhian added a comment. In D110111#3013948 , @tlively wrote: > Nice! Thanks for writing this :D Do you know what happens when you actually > try to compile some code with `-mrelaxed-simd`? I'm concerned that it will > throw an error because the "relaxe

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-21 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. Nice! Thanks for writing this :D Do you know what happens when you actually try to compile some code with `-mrelaxed-simd`? I'm concerned that it will throw an error because the "relaxed-simd" target feature has not yet been defined in the backend (specifically in WebAs

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-20 Thread Ng Zhi An via Phabricator via cfe-commits
ngzhian added a comment. I followed https://reviews.llvm.org/rGb7b9fdc114c1f9c788da914dac5c343277805446 for this, hope it's right, ptal Thomas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111 ___

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

2021-09-20 Thread Ng Zhi An via Phabricator via cfe-commits
ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: dang, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This currently only de