thakis added a comment.
Fixed in
https://github.com/llvm/llvm-project/commit/8ecf3660f2de3b88d10db0fd52d0bc80bda33dcc
, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110315/new/
https://reviews.llvm.org/D110315
thakis added a comment.
Arm Mac: http://45.33.8.238/macm1/18463/step_7.txt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110315/new/
https://reviews.llvm.org/D110315
___
cfe-commits mailing list
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3778c1cd6ef5: [Sema] Fix a null pointer reference crash.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:14496
- if (FSI->UsesFPIntrin && !FD->hasAttr())
+ if (FSI->UsesFPIntrin && FD && !FD->hasAttr())
FD->addAttr(StrictFPAttr::CreateImplicit(Context));
sammccall wrote:
> hokein wrote:
hokein updated this revision to Diff 374538.
hokein added a comment.
upload a minimized testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110315/new/
https://reviews.llvm.org/D110315
Files:
clang/lib/Sema/SemaDecl.cpp
sammccall accepted this revision.
sammccall added a subscriber: mibintc.
sammccall added a comment.
This revision is now accepted and ready to land.
LG because not crashing here is surely better than crashing, but I'm not sure
whether the behaviour is actually right.
If we can't be sure, maybe
hokein added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:14496
- if (FSI->UsesFPIntrin && !FD->hasAttr())
+ if (FSI->UsesFPIntrin && FD && !FD->hasAttr())
FD->addAttr(StrictFPAttr::CreateImplicit(Context));
I have a reproduce test case, and
hokein created this revision.
hokein added a reviewer: sammccall.
hokein requested review of this revision.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D110315
Files:
clang/lib/Sema/SemaDecl.cpp
Index: clang/lib/Sema/SemaDecl.cpp
