[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

This revision was automatically updated to reflect the committed changes. mtrofin marked an inline comment as done. Closed by commit rG7d541eb4d49a: [inliner] Mandatory inlining decisions produce remarks (authored by mtrofin). Changed prior to commit:

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks accepted this revision. aeubanks added a comment. lg, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 ___ cfe-commits mailing list

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin marked an inline comment as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult ) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin updated this revision to Diff 377091. mtrofin marked 2 inline comments as done. mtrofin added a comment. added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 Files:

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult ) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined",

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

dblaikie added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; mtrofin wrote: > wenlei wrote: > > mtrofin wrote: > > > wenlei wrote: > > > > curious why do we need anonymous namespace here? > > >

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin marked 3 inline comments as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; wenlei wrote: > mtrofin wrote: > > wenlei wrote: > > > curious why do we need anonymous

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult ) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined",

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; mtrofin wrote: > wenlei wrote: > > curious why

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin marked an inline comment as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; wenlei wrote: > curious why do we need anonymous namespace here? iiuc it's preferred we place

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:52 +namespace { +using namespace llvm::ore; curious why do we need anonymous namespace here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

mtrofin created this revision. mtrofin added a reviewer: aeubanks. Herald added subscribers: ormris, wenlei, hiraditya, eraman. mtrofin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This also removes the need to disable