[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

2021-10-06 Thread Pushpinder Singh via Phabricator via cfe-commits
pdhaliwal updated this revision to Diff 377502. pdhaliwal added a comment. Only removing optnone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111218/new/ https://reviews.llvm.org/D111218 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index:

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

2021-10-06 Thread Pushpinder Singh via Phabricator via cfe-commits
pdhaliwal planned changes to this revision. pdhaliwal added a comment. I don't have any concrete evidence but I have some doubt on presence of function pointers causing backend to behave improperly. Also, here removing optnone alone suffices to fix the issue. Repository: rG LLVM Github

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

2021-10-06 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield edited reviewers, added: tianshilei1992, ye-luo, grokos; removed: ggeorgakoudis. JonChesterfield added a comment. Not pretty but unblocking D102107 is important. Could you write up your current understanding of what we're miscompiling for

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

2021-10-06 Thread Pushpinder Singh via Phabricator via cfe-commits
pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, jdoerfert, jhuber6, ggeorgakoudis. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald