[PATCH] D111457: [test] Add lit helper for windows paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6541d3e979c1: [test] Add lit helper for windows paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 415290. keith added a comment. Update substitutions to use dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: llvm/docs/CommandGuide/lit.rst

[PATCH] D111457: [test] Add lit helper for windows paths

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, though I'm not a fan of the variable names - they seem a bit difficult to read due to no separation (e.g., `%fs-src-root` or `%fs_src_root` vs `%fssrcroot`)

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. Herald added a project: All. @compnerd can you re-review here? I think I covered your feedback, let me know! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D111457: [test] Add lit helper for windows paths

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. For reference here's an example of a test that uses this https://reviews.llvm.org/D111579 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D111457: [test] Add lit helper for windows paths

keith added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ probinson wrote: > rnk wrote: > > It is pretty common to run the LLVM test suite on secondary drives, > >

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 411921. keith marked 3 inline comments as done. keith edited the summary of this revision. keith added a comment. Use the actual drive on windows, split out into fssrcroot and fstmproot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111457: [test] Add lit helper for windows paths

probinson added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ rnk wrote: > It is pretty common to run the LLVM test suite on secondary drives, > especially on

[PATCH] D111457: [test] Add lit helper for windows paths

rnk added inline comments. Comment at: llvm/docs/TestingGuide.rst:577 +``${fssep}`` + Exp``ands to the file system separator, i.e. ``/`` or ``\`` on Windows. + Stray backticks in "Expands"? Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +