This revision was automatically updated to reflect the committed changes.
Closed by commit rGcb22d71806b7: [clang] Fix DIFile directory root on Windows
(authored by keith).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.ll
keith updated this revision to Diff 415291.
keith marked an inline comment as done.
keith added a comment.
Update subsitutions with dashes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.llvm.org/D111579
Files:
clang/li
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGen/debug-prefix-map.c:7
+// RUN: %clang -g -fdebug-prefix-map=%p=%{fssrcroot}UNLIKELY_PATH%{fssep}empty
-S -c %s -emit-llvm -o - | FileCh
keith added a comment.
Ping, all green here, I just had to mess with the test regex a bit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.llvm.org/D111579
___
cfe-commits mailin
keith updated this revision to Diff 415004.
keith added a comment.
Replace \w with .
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.llvm.org/D111579
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/test/CodeGen/debug-p
keith updated this revision to Diff 414976.
keith added a comment.
Herald added a project: All.
Remove variables from test expectations
This didn't work out because of the double vs single slash of the expansions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews
keith updated this revision to Diff 411922.
keith added a comment.
Update tests with new syntax and FileCheck variables
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.llvm.org/D111579
Files:
clang/lib/CodeGen/CGDebugIn
keith updated this revision to Diff 411575.
keith marked 3 inline comments as done.
keith added a comment.
Add more test path changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
https://reviews.llvm.org/D111579
Files:
clang/lib/Cod
keith added inline comments.
Comment at: clang/test/CodeGen/debug-prefix-map.c:24
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}",
+// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "")
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(f
mstorsjo added inline comments.
Comment at: clang/test/CodeGen/debug-prefix-map.c:24
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}",
+// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "")
+// CHECK-NO-MAIN-FILE-NAME: !DIFil
keith added inline comments.
Comment at: clang/test/CodeGen/debug-prefix-map.c:24
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename:
"{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}",
+// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "")
+// CHECK-NO-MAIN-FILE-NAME: !DIFile(f
mstorsjo added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:439
+if (llvm::sys::path::root_path(DirBuf) == DirBuf) {
+ // Don't strip the common prefix if it is only the root ("/" or "C:\")
// since that would make LLVM diagnostic locations confu
keith added a reviewer: compnerd.
keith added a comment.
Adding since you might be interested in this, I think the Swift logic is also
derived from this so it might have the same difference.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111579/new/
keith created this revision.
keith requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
On unix systems this logic would not separate the file and directory of
the DIFile unless they shared more components at the start than just the
root path ch
14 matches
Mail list logo
