[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong marked an inline comment as done. martong added a comment. Thanks for the assiduous review guys! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111642/new/ https://reviews.llvm.org/D111642 ___ cfe

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG888af47095d5: [Analyzer][solver] Simplification: reorganize equalities with adjustment (authored by martong). Changed prior to commit: https://rev

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Awesome! So clean, and I also like the tests. Good job. Comment at: clang/test/Analysis/solver-sym-simplification-adjustment.c:58 + if (b != 1) { // b == 1 --> c

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong added a comment. In D111642#3059467 , @steakhal wrote: > The coverage report of the test shows that L2124 is uncovered. Please add a > test demonstrating that path as well. I've added such a test, thanks for the notice! Comme

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong updated this revision to Diff 381536. martong added a comment. - Add a test to cover `if (OldState == State)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111642/new/ https://reviews.llvm.org/D111642 Files: clang/lib/StaticAnalyzer/Core

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong updated this revision to Diff 381520. martong marked 3 inline comments as done. martong added a comment. - Add comment about intersection in the test file - Add check in the feasible case in the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2126-2130 + // Initiate the reorganization of the equality information. E.g., if we + // have `c + 1 == 0` then we'd like to express that `c == -1`. It makes + // s

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

steakhal added a comment. The coverage report of the test shows that L2124 is uncovered. Please add a test demonstrating that path as well. I'm gonna come back to this tomorrow. Comment at: clang/test/Analysis/solver-sym-simplification-adjustment.c:36 + clang_analyzer_warnIfR

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong req