dexonsmith added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58
+ // Ensure the reported context hash is strict.
+ CI.getHeaderSearchOpts().ModulesStrictContextHash = true;
+
jansvoboda11 wrote:
> dexonsmith wrote
This revision was automatically updated to reflect the committed changes.
Closed by commit rG954d77b98dd6: [clang][deps] Ensure reported context hash is
strict (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D111720?vs=379397&id=381213#toc
Repository:
rG LLVM Gi
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58
+ // Ensure the reported context hash is strict.
+ CI.getHeaderSearchOpts().ModulesStrictContextHash = true;
+
dexonsmith wrote:
> jansvoboda11 wro
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, if you expand the comment (see inline).
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58
+ // Ensure the reported context hash is
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58
+ // Ensure the reported context hash is strict.
+ CI.getHeaderSearchOpts().ModulesStrictContextHash = true;
+
dexonsmith wrote:
> IIUC, explicit m
dexonsmith added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58
+ // Ensure the reported context hash is strict.
+ CI.getHeaderSearchOpts().ModulesStrictContextHash = true;
+
IIUC, explicit modules don't really ha
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
One of main goals of the dependency scanner is to be strict about module
compatibility. T
