[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman closed this revision. aaron.ballman added a comment. I landed the non-pmf changes in b9941de0bfac4bad93e11dff26396e34a53e3891 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111817/new/ https://reviews.ll

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman updated this revision to Diff 379795. aaron.ballman added a comment. Updated the patch to add new test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111817/new/ https://reviews.llvm.org/D111817 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/cxx2a-con

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } aaron.ballman wrote: > erichkeane wrote: > > rsmith wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > > > Was thi

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } erichkeane wrote: > rsmith wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > Was this one missed too? > > > I could

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } rsmith wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Was this one missed too? > > I c

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: clang/lib/Sema/SemaOverload.cpp:14290 return MaybeBindToTemporary(call); } aaron.ballman wrote: > erichkeane wrote: >

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:13800 ExprResult R = MaybeBindToTemporary(TheCall); if (R.isInvalid()) erichkeane wrote: > Wonder if as a 'while we're here' we should make this the same as the o

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

erichkeane added a comment. This seems like two places this was missed in: https://reviews.llvm.org/D63960 however I see a another place grepping around we might have missed too? Can you find a way to write tests for that? Also, perhaps 1 more cleanup? Comment at: clang/lib

[PATCH] D111817: Fix a rejects-valid with consteval on overloaded operators

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. It seems that Clang 11 regressed functionality that was working in Clang 10 regarding calling a few overloaded operator