[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D112019#3378031 , @MyDeveloperDay wrote: > In D112019#3378024 , > @HazardyKnusperkeks wrote: > >> Why limit to macros, could it b

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay added a comment. In D112019#3378024 , @HazardyKnusperkeks wrote: > Why limit to macros, could it be a member of AlignConsecutiveStyle and apply > to the other stuff as well? I personally don't have a use case other than the resource.h ca

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay updated this revision to Diff 414950. MyDeveloperDay marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112019/new/ https://reviews.llvm.org/D112019 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/l

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks added a comment. Why limit to macros, could it be a member of AlignConsecutiveStyle and apply to the other stuff as well? Comment at: clang/include/clang/Format/Format.h:256 + /// \endcode + /// \version 14 + unsigned AlignConsecutiveMacrosMinWidth; -

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112019/new/ https://reviews.llvm.org/D112019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay updated this revision to Diff 414938. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Herald added a project: All. Address review comments and update for current trunk (up the first supported version in the documentation) CHANGES SINCE LAST ACTION

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

curdeius added a comment. Please review the descriptions. Looks good, but I'm wondering if there are better names for these options. E.g. when `AlignConsecutiveMacrosIgnoreMax` is true, then `AlignConsecutiveMacrosMinWidth` is not minimum width, but required/fixed width except for long macro nam

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay added a comment. In D112019#3073628 , @HazardyKnusperkeks wrote: > Otherwise it looks good. Thanks @HazardyKnusperkeks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112019/new/ https://rev

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Otherwise it looks good. Comment at: clang/include/clang/Format/Format.h:245 + /// \version 14 + bool AlignConsecutiveMacrosIgnoreMax; + ---

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. clang-format `AlignConsecutiveMacros` feature causes real problems when using Win32 r