[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-21 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/null -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s --che

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/null -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s --che

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-21 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2dcad7754a20: [clang] Don't clear AST if we have consumers running after the main action (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-21 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/null -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s --che

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112190/new/ https://reviews.llvm.org/D112190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-20 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/n

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-20 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 381112. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112190/new/ https://reviews.llvm.org/D112190 Files: clang/lib/Frontend/FrontendAction.cpp clang/test/Misc/clear-ast-b

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

2021-10-20 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Downstream users may have Clang plugins. By default these plugins run after the main action if they are specified on the command line. Since these plu