[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov abandoned this revision. azabaznov added a comment. Now program scope global variables are required by device enqueue in the spec, new patch for device enqueue support: https://reviews.llvm.org/D115640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9554 + +const auto &OpenCLFeaturesMap = +Info.Ctx.getTargetInfo().getSupportedOpenCLOpts(); azabaznov wrote: > azabaznov wrote: > > Anastasia wrote: > > > What test case cover

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9554 + +const auto &OpenCLFeaturesMap = +Info.Ctx.getTargetInfo().getSupportedOpenCLOpts(); azabaznov wrote: > Anastasia wrote: > > What test case covers this change? It feels

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added a comment. Herald added a subscriber: Naghasan. > How about we clarify with Khronos whether it would be sufficient to add a > restriction like: > >> Program scope blocks are only supported when program scope variables feature >> is supported. That's sounds good to me. Especially

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added a comment. In D112230#3078231 , @azabaznov wrote: > @Anastasia, @yaxunl, do you think it's possible to refactor code generation > for blocks such that block literal for global blocks (with no captures) would > be emitted in constant addr

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added a comment. @Anastasia, @yaxunl, do you think it's possible to refactor code generation for blocks such that block literal for global blocks (with no captures) would be emitted in constant address space? Now it's emitted in global address space (for example @__block_literal_globa

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, yaxunl, svenvh. Herald added a subscriber: ldrumm. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This feature requires support of __opencl_c_generic_address_