[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG897c86dec5af: [clang] [MinGW] Rename the Arch member to SubdirName. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112387/new/

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

mstorsjo updated this revision to Diff 382798. mstorsjo added a comment. Renamed the variable to `SubdirName`. Will push tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112387/new/ https://reviews.llvm.org/D112387 Files:

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

MaskRay added a comment. Making the word `Subdir` part of the variable name LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112387/new/ https://reviews.llvm.org/D112387 ___ cfe-commits mailing list

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

mstorsjo added a comment. In D112387#3090707 , @MaskRay wrote: > How is this different from `clang::driver::Driver::SysRoot`? > > From `SysrootName + "/sys-root"` looks like the `sys-root` directory is the > sysroot? Perhaps there is a better way

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. How is this different from `clang::driver::Driver::SysRoot`? From `SysrootName + "/sys-root"` looks like the `sys-root` directory is the sysroot? Perhaps there is a better way describing

[PATCH] D112387: [clang] [MinGW] Rename the 'Arch' member to 'SysrootName'. NFC.

mstorsjo created this revision. mstorsjo added a reviewer: MaskRay. mstorsjo requested review of this revision. Herald added a project: clang. This string isn't a plain architecture name, but contains the whole subdir name used for the sysroot, which often is equal to the target triple.