This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe6d0b851f854: [ARM][libunwind] add PACBTI-M support for
libunwind (authored by stuij).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
stuij updated this revision to Diff 390333.
stuij added a comment.
uploading after rebase as per reviewer request (no changes in the patch itself)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112430/new/
https://reviews.llvm.org/D112430
Files:
ldionne added a comment.
Please rebase onto `main` and re-upload before submitting, so that the CI runs.
There was a flaky failure previously, but I'd like to see it run before merging.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112430/new/
htt
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
I guess this is ok then. I can't say I've followed every bit in detail, but it
looks sensible overall.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
stuij updated this revision to Diff 389481.
stuij added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112430/new/
https://reviews.llvm.org/D112430
Files:
clang/lib/Headers/unwind.h
libunwind/include/libunwind
chill added inline comments.
Comment at: libunwind/src/Unwind-EHABI.cpp:312
uint8_t registers = getByte(data, offset++);
- if (registers & 0xf0 || !registers)
+ if (registers & 0xf0)
return _URC_FAILURE;
m
mstorsjo added a comment.
Looks overall ok, without diving in very deep, except for this one change that
seemed unrelated.
Comment at: libunwind/src/Unwind-EHABI.cpp:312
uint8_t registers = getByte(data, offset++);
- if (registers & 0xf0 || !registe
danielkiss accepted this revision.
danielkiss added a comment.
LGTM, Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112430/new/
https://reviews.llvm.org/D112430
___
cfe-commits mailing list
cfe-co
stuij updated this revision to Diff 387237.
stuij added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112430/new/
https://reviews.llvm.org/D112430
Files:
clang/lib/Headers/unwind.h
libunwind/include/libunwi
danielkiss added inline comments.
Comment at: libunwind/src/Registers.hpp:2245-2246
+ if (regNum == UNW_ARM_RA_AUTH_CODE)
+return true;
+
Maybe we could gate this on __ARM_FEATURE_PAUTH because it won't work anyway
without the feature enabled for libunwin
stuij created this revision.
Herald added subscribers: libcxx-commits, kristof.beyls.
Herald added a project: libunwind.
Herald added a reviewer: libunwind.
stuij requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch implements the fol
11 matches
Mail list logo
