HsiangKai updated this revision to Diff 395365.
HsiangKai added a comment.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
In riscv-insert-vsetvli, use the policy argument. No use implicit-def maskedoff
to adjust the setting.
Repository:
rG LLVM Github Monorep
HsiangKai updated this revision to Diff 394782.
HsiangKai added a comment.
Herald added a subscriber: jdoerfert.
Update attribute test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
Files:
clang
HsiangKai updated this revision to Diff 394766.
HsiangKai added a comment.
Fix build errors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
Files:
clang/include/clang/Basic/Attr.td
clang/include/clan
HsiangKai updated this revision to Diff 394751.
HsiangKai added a comment.
Address @craig.topper and @frasercrmck's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
Files:
clang/include/clang/B
HsiangKai added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610
unsigned NF = 1;
constexpr unsigned TAIL_UNDISTURBED = 0;
+ constexpr unsigned TAIL_AGNOSTIC = 0b01;
HsiangKai wrote:
> craig.topper wrote:
> > Is constant still used?
> Yes
HsiangKai added inline comments.
Herald added subscribers: VincentWu, luke957.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610
unsigned NF = 1;
constexpr unsigned TAIL_UNDISTURBED = 0;
+ constexpr unsigned TAIL_AGNOSTIC = 0b01;
craig.topper wrote:
> Is c
luke957 resigned from this revision.
luke957 added a comment.
So sorry for my bad herald script.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
___
cfe-commits
frasercrmck added a comment.
Herald added a reviewer: luke957.
Just nits from me at this stage.
Comment at: clang/include/clang/Basic/AttrDocs.td:2150
+ let Content = [{
+Users could use the attribute to specify the policy of destination tail and
+destination inactive masked-o
craig.topper added a comment.
I think the concept seems good to me. I'd like @aaron.ballman to review the
attribute code.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610
unsigned NF = 1;
constexpr unsigned TAIL_UNDISTURBED = 0;
+ constexpr unsigned TAIL_AGNOSTIC = 0b0
HsiangKai updated this revision to Diff 382529.
HsiangKai added a comment.
Address @craig.topper's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
Files:
clang/include/clang/Basic/Attr.td
cl
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18614
+ auto *PolicyAttr = E->getCalleeDecl()->getAttr();
+ size_t PolicyValue;
Why size_t? This would be the size_t of the host machine that's
building/running the compiler and
HsiangKai updated this revision to Diff 382298.
HsiangKai added a comment.
Remove redundant test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112534/new/
https://reviews.llvm.org/D112534
Files:
clang/include/clang/Basic/Attr.td
clang/in
HsiangKai created this revision.
HsiangKai added reviewers: kito-cheng, craig.topper, frasercrmck, rogfer01.
Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, Ma
13 matches
Mail list logo
