This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b1fd19357be: [CodeGen] Diagnose and reject non-function
ifunc resolvers (authored by ibookstein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112868/new/
ibookstein added a comment.
Yeah, it's real ugly from a CFE/LLVM separation POV. I also can't avoid seeing
it as a duplication of the verifier's logic. But emitting diagnoses is better
than asserting/crashing...
For the recursion, maybe an equivalent of `getAliaseeObject` on `GlobalDecl`-s
coul
MaskRay accepted this revision.
MaskRay added a comment.
I assume that dancing with GlobalValue makes this difficult to implement in
lib/Sema.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112868/new/
https://reviews.llvm.org/D112868
ibookstein updated this revision to Diff 385926.
ibookstein added a comment.
rebase fix after adding parent NFC commits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112868/new/
https://reviews.llvm.org/D112868
Files:
clang/lib/CodeGen/CodeGenMo
ibookstein updated this revision to Diff 385606.
ibookstein added a comment.
move test from Sema to CodeGen (trying to make arcanist send multiple
separate commits..?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112868/new/
https://reviews.llvm.o
ibookstein updated this revision to Diff 385603.
ibookstein retitled this revision from "[Sema] Diagnose and reject non-function
ifunc resolvers" to "[CodeGen] Diagnose and reject non-function ifunc
resolvers".
ibookstein added a comment.
move attr-ifunc.c test to codegen
Repository:
rG LLVM
