[PATCH] D113145: Remove two sema checkings as assertions introduced by D79719.

2021-11-04 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. Yeah, that would be better. I just realized it earlier today. I'll attempt that instead. Thanks for the suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113145/new/ https://reviews.llvm.org/D113145

[PATCH] D113145: Remove two sema checkings as assertions introduced by D79719.

2021-11-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. @ychen, an alternative fix would be to avoid getting asking for the layout for a broken `union` like this. Would it be appropriate to mark the `RecordDecl` in Sema such that `isInvalidDecl` returns true? Is that already happening? Repository: rG LLVM

[PATCH] D113145: Remove two sema checkings as assertions introduced by D79719.

2021-11-03 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen created this revision. ychen added reviewers: hubert.reinterpretcast, Xiangling_L. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sema layer should handle these already. Otherwise checking build of the compiler would crash for