[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. Sorry for taking so long to get back to you on this matter... In D113268#3112026 , @sammccall wrote: >> For someone unfamiliar with the tool, is there a simple "smoke test >> procedure" I could try out with it to kick the tyres

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo updated this revision to Diff 388857. mstorsjo added a comment. Added a comment about the surprising change where the order of append and native is switched. Made the modification to `testRoot()` less hacky. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:546 fs::make_absolute(TestScheme::TestDir, Path); +path::native(Path); return std::string(Path); mstorsjo wrote: > sammccall wrote: > > This change is an exampl

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. In D113268#3111995 , @mstorsjo wrote: >> I think the biggest testing problem we have though is that we don't have a >> good way of defining integration tests with paths set up the right way >> (since we can't really use absolu

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. In D113268#3111798 , @sammccall wrote: > In D113268#3111709 , @mstorsjo > wrote: > >> FWIW, this change is not about mingw, it's about making the >> windows-with-forward-slashes configu

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. Oh, I realized that issues relating to “mingw” probably are from msys (which often is used together, but is an entirely different thing) - yeah I can see that there’d be lots of unfixable issues with that, and I’m not signing up for looking into that… Msys is the unix

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. In D113268#3111709 , @mstorsjo wrote: > FWIW, this change is not about mingw, it's about making the > windows-with-forward-slashes configuration usable. OK - can I ask why the windows-with-forward-slashes configuration is valu

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. I forgot to add - I agree with the general sentiment though, that it’s not worth bending over backwards to make tests pass in a setup that’s known not to work in real use though. Then again, if someone were to want to actually step up to make it work in mingw setups,

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a reviewer: kadircet. sammccall added a comment. Ooh sorry, I was missing some context. I see now that LLVM_WINDOWS_PREFER_FORWARD_SLASH, `windows_backslash` etc are new work. And maybe buildbots are coming? It's possible that the combination of our windows support plus improved

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a subscriber: rnk. mstorsjo added a comment. FWIW, this change is not about mingw, it's about making the windows-with-forward-slashes configuration usable. The windows-with-forward-slashes configuration works just as fine in MSVC configurations, and that's where I've tested it. A

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. TL;DR: clangd is unsupported/broken on mingw, this patch only makes the tests pass. The current maintainers don't plan to invest in this, or accept much extra complexity to support it. If you or someone wants to find a clean way to support the configuration, it'd be g

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo created this revision. mstorsjo added reviewers: sammccall, aaron.ballman. Herald added subscribers: usaxena95, kadircet, arphaman. mstorsjo requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. If running on Window