[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD added a comment. In D113336#3313909 , @junparser wrote: > @eopXD, hi, this patch make us lost +relax and -save-restore by default, > would you please fix it? Sure, let me look into it. Do you have an existing test case for your situation? (Or I

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

junparser added a comment. Herald added a subscriber: pcwang-thead. @eopXD, hi, this patch make us lost +relax and -save-restore by default, would you please fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG60b6e73769f8: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ htt

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401541. eopXD marked an inline comment as done. eopXD added a comment. Update code based on @kito-cheng 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 File

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Otherwise LGTM. Comment at: clang/lib/Basic/Targets/RISCV.cpp:220 - return TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec); + unsigned XLen = Featur

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD added a comment. This patch needs to be landed before D112613 because clang_cc1 needs to do correct implication from `v`, `zve32f`, `zve64f` and `zve64d` and this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401525. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp llvm/include/llvm/Sup