[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

toddcarmay added a comment. Herald added a project: All. I've been trying to find anything like this for a while now. Thanks for posting this, I've been hunting for it for a while. https://drift-boss.co/ drift boss Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

This revision was automatically updated to reflect the committed changes. Closed by commit rG9efce0baee4b: [clang] Run LLVM Verifier in modes without CodeGen too (authored by ibookstein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ htt

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein added a comment. Thanks; Might I ask that you commit this on my behalf? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ https://reviews.llvm.org/D113352 ___ cfe-commits mailing li

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5016 llvm::Constant *Resolver = - GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, GD, + GetOrCre

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5016 llvm::Constant *Resolver = - GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, GD, + GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, {},

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5016 llvm::Constant *Resolver = - GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, GD, + GetOrCreateLLVMFunction(IFA->getResolver(), ResolverTy, {},

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein marked an inline comment as done. ibookstein added a comment. In D113352#3114009 , @dblaikie wrote: > I guess CodeGenOpts::VerifyModule is on by default, but I'll admit that > surprises me - for API-built modules, I figured it was expected the

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein updated this revision to Diff 385361. ibookstein edited the summary of this revision. ibookstein added a comment. Herald added subscribers: steven_wu, hiraditya. - Fixed PR comment about documentation - Amended clang/test/CodeGen/lto-newpm-pipeline.c to reflect change - Fixed small bug

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

rjmccall added a comment. Seems like a good idea to me. Minor request; otherwise, feel free to commit. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1438 +// Add it here so that it runs prior to the BC/LL emission pass +MPM.addPass(VerifierPass()); + T

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

dblaikie added a comment. I guess CodeGenOpts::VerifyModule is on by default, but I'll admit that surprises me - for API-built modules, I figured it was expected they were valid by construction (ie: like an assertion - it's a bug in clang if the resulting module isn't valid - so we wouldn't wan

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein updated this revision to Diff 385298. ibookstein added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ https://reviews.llvm.org/D113352 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib/Code

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

ibookstein created this revision. ibookstein added reviewers: dblaikie, rjmccall. Herald added a subscriber: ormris. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the Backend_Emit{Nothing,BC,LL} modes did not run th