[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb786a4aefeda: [clang-format] Extend SpaceBeforeParens for requires (authored by HazardyKnusperkeks). Changed prior to commit:

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4007 + * ``bool AfterRequiresKeywordInRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4007 + * ``bool AfterRequiresKeywordInRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if there is one.

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. My naming suggestion is not binding. I have no strong opinion on this, but a shorter name would get my  :). So please sync with other reviewers. Comment at:

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added a comment. I need a response here. :) @Quuxplusone are the names okay for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 ___ cfe-commits mailing list

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added a comment. A friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/include/clang/Format/Format.h:3371 +/// If ``true``, put space between requires keyword in a requires clause and +/// opening parentheses, if there is one. +/// \code HazardyKnusperkeks wrote: >

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks requested review of this revision. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 406450. HazardyKnusperkeks marked 4 inline comments as done. HazardyKnusperkeks added a reviewer: curdeius. HazardyKnusperkeks removed a subscriber: curdeius. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. -

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + HazardyKnusperkeks

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + Quuxplusone

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

Quuxplusone added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + HazardyKnusperkeks

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Delayed until D113319 is resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3145-3148 + else { +assert(Left.is(TT_RequiresExpression)); +return Style.SpaceBeforeParensOptions.AfterRequiresExpression; + } Nit: remove `else`.

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (nit the clang-format check) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 385594. HazardyKnusperkeks added a comment. Now the new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 Files:

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + curdeius

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 385588. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + You meant "if there is

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, crayroud. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can