[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks! Delighted to see the subclasses gone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 __

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385627. atmnpatel added a comment. small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp clang/lib/Code

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385626. atmnpatel added a comment. Yep yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp clang/lib/CodeGen

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

JonChesterfield added a comment. I think __kmpc_get_warp_size needs an entry in Utils.cpp keepAlive(), and corresponding functions added to `deviceRTLs/*/src/target_impl.*` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

tianshilei1992 accepted this revision. tianshilei1992 added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 ___ cfe-commits mailing list cfe-commi

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385615. atmnpatel added a comment. Remove intrinsic includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 Files: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:23 #include "llvm/Frontend/OpenMP/OMPGridValues.h" +#include "llvm/IR/IntrinsicsAMDGPU.h" #include "llvm/IR/In

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel updated this revision to Diff 385611. atmnpatel added a comment. Herald added projects: OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits. Updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://revie

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

JonChesterfield added a comment. Example of the function as opposed to intrinsics is __kmpc_get_hardware_num_threads_in_block from just above where you've modified. That corresponds to a function in the device runtime, e.g. int __kmpc_get_hardware_num_threads_in_block() { return get_workg

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

jdoerfert added a comment. In D113421#3116155 , @tianshilei1992 wrote: > I remember at some point we want to just emit function call to get those > information like thread id. Yes, no intrinsics please. Add `__kmpc_get_warp_size` and similar functions

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

tianshilei1992 added a comment. I remember at some point we want to just emit function call to get those information like thread id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113421/new/ https://reviews.llvm.org/D113421 __

[PATCH] D113421: [clang][openmp][NFC] Remove arch-specific CGOpenMPRuntimeGPU files

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, JonChesterfield, tianshilei1992. Herald added subscribers: asavonic, guansong, yaxunl, mgorny, jvesely, jholewinski. atmnpatel requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a p