[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks abandoned this revision. aeubanks added a comment. I posted an RFC a while back for basically removing size levels from optimization levels but never seriously looked into it: https://groups.google.com/g/llvm-dev/c/NrZsR8OZTts/m/P5t14TKaAQAJ Repository: rG LLVM Github Monorepo CHAN

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. D72404 has some comments why the -Os/-Oz levels are discouraged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

thevinster added inline comments. Comment at: lld/Common/Args.cpp:29 +OptimizationLevel args::getOptLevel(llvm::opt::InputArgList &args, +unsigned int key, nit: `getOptLevel` seems a bit too generic for something that's LTO s

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

pcc added a comment. Please see D63976 where we rejected a similar change in favor of just letting this be controllable at compile time. To the extent that the pass pipeline is affected by the size optimization level, I think we should change the passes so that

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks updated this revision to Diff 386882. aeubanks added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/Config.h lld

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

fhahn added a comment. Could you add tests on the LLVM side for the new options as well? See also D95541 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks updated this revision to Diff 386748. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/Config.h lld/COFF/Dr

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, mgorny, emaste. Herald added a reviewer: MaskRay. Herald added a reviewer: gkm. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. aeubanks requested review o