[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeecfc73ae4b9: [clangd] Record IWYU pragma keep in the IncludeStructure (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392753. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: clang-

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! sorry for taking so long. Comment at: clang-tools-extra/clangd/Headers.cpp:142 private: + // Level will be increased every time we enter the file and redu

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392696. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address the last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: clang

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392688. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve almost all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: cl

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:126 + bool HandleComment(Preprocessor &PP, SourceRange Range) override { +if (!isInsideMainFile(Range.getBegin(), SM) || Range.getBegin().isMacroID()) + return false; we'r

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:130 + // IWYU pragmas but it needs to be explicitly added to as a preprocessor + // comment handler. PP wants to own the PPCallbacks, so the typical way to + // do both is: sammccal

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 390639. kbobyrev marked an inline comment as done. kbobyrev added a comment. Fix failures, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 F

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 390631. kbobyrev marked an inline comment as done. kbobyrev added a comment. Change the API, update the patch. It's crashing ATM, investigating the problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added a comment. > Sorry for forgetting about this one. Hopefully I can still help now by > disagreeing with Kadir and creating an awkward stalemate instead. Haha, always welcome! > Partly because the ordering isn't some weird coincidence (see below) Right, I suppose it makes sense wh

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

sammccall added a comment. Didn't really address this part > But I don't think it matters in the long run especially when we want to > handle different types of pragmas in the future > So I'd suggest just building a side table information That's a more general approach for sure. But it does see

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

sammccall added a comment. Sorry for forgetting about this one. Hopefully I can still help now by disagreeing with Kadir and creating an awkward stalemate instead. I agree that the ownership situation is ugly, but I think a single object here is still simpler. Partly because the ordering isn't

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added a comment. It's annoying that we see comments and inclusion directives out-of-order, we can try fixing it on the parser side (I think it is incidental that these are issued in that order currently, they are eagerly trying to generate a fix/diagnostic for tokens after a pp-directi

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will allow the IncludeClea