[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This is a WIP, to start the discussion. I've only turned on the X86 backend. Otherwise should be functional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/ https://reviews.llvm.org/D114082 ___

[PATCH] D114082: [WIP] Normalize String Attributes

Nuu added a comment. Thanks for this. I planned something similar to turn string literal typo errors into compile errors as well. The typos are really hard to identify :-P Some suggestions on using tablegen. Comment at: llvm/include/llvm/IR/Attributes.h:977-1133 +constexp

[PATCH] D114082: [WIP] Normalize String Attributes

mehdi_amini added a comment. The patch is pretty large, any chance you could split in two? First the change introducing the AttributeKey and changing the API, and then updating all the callees separately as a follow up? Comment at: llvm/include/llvm/IR/Attributes.h:84 + } +}

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This diff is indeed very large. I reworked it in https://reviews.llvm.org/D114394 to capture the essence of it, on which we could then rebase this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/

[PATCH] D114082: [WIP] Normalize String Attributes

rnk added subscribers: void, rnk. rnk added a comment. > it is possible to list all internal keys in one place I think one of the original goals of adding support for string attributes (maybe @void will give some input) was specifically to avoid having one giant list with all the attributes sup

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. In D114082#3149631 , @rnk wrote: >> it is possible to list all internal keys in one place > > I think one of the original goals of adding support for string attributes > (maybe @void will give some input) was specifical