[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3161978 , @nikic wrote: > FYI I reverted this due to test failures -- one specific assertion failure is > mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Thanks! I saw the failures and was going to revert,

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

fhahn added a comment. It is also breaking building `llvm-project/llvm/unittests/Support/Host.cpp` on macOS: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/25781/consoleFull FAILED: unittests/Support/CMakeFiles/SupportTests.dir/Host.cpp.o /Applications/Xcode.app/Co

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

nikic added a comment. FYI I reverted this due to test failures -- one specific assertion failure is mentioned in https://reviews.llvm.org/rG40d5eeac6cd8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.org/D114163

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e8286467036: Use VersionTuple for parsing versions in Triple. This makes it possible to… (authored by jamesfarrell). Repository: rG LLVM Github M

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3160292 , @arphaman wrote: > Sorry for delay, this LGTM. Thanks for doing this cleanup! Thanks, and no worries about the time (I was out last week as well) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Sorry for delay, this LGTM. Thanks for doing this cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.or

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added inline comments. Comment at: clang/test/Sema/attr-availability-android.c:8 #ifdef WARN_PARTIAL -// expected-note-re@+2 {{'f3' has been marked as being introduced in Android 19 here, but the deployment target is Android 16.0.0{{$ +// expected-note-re@+2 {{

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell added a comment. In D114163#3143534 , @danalbert wrote: > Nice, that's a lot of code cleaned up! LGTM, but probably should wait for > someone from Apple to weigh in. I think the new formatting for those error > messages is better for them t

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

dexonsmith added a reviewer: arphaman. dexonsmith added a subscriber: arphaman. dexonsmith added a comment. This revision now requires review to proceed. @arphaman , can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ htt

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but t

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell updated this revision to Diff 388198. jamesfarrell added a comment. Remove an include that's no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.org/D114163 Files: clang/lib/ARCMigrate/AR

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

jamesfarrell updated this revision to Diff 388196. jamesfarrell retitled this revision from "Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.See also https://github.com/android/ndk/iss

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible. See also https://gith

jamesfarrell created this revision. Herald added subscribers: danielkiss, dexonsmith, pengfei, hiraditya. jamesfarrell requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.