MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.
Request changes according to the outstanding comment "But in general I'm not in
favor of adding a dependence on having the LTO plugin available to all non-lld
links by default."
serge-sans-paille added subscribers: rsmith, serge-sans-paille.
serge-sans-paille added a comment.
Gentle ping @MaskRay and/or @rsmith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114229/new/
https://reviews.llvm.org/D114229
tejohnson added inline comments.
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:558
assert(!Inputs.empty() && "Must have at least one input.");
addLTOOptions(ToolChain, Args, CmdArgs, Output, Inputs[0],
D.getLTOMode() == LTOK_Thin);
tbaeder added a comment.
The test failures are pretty obvious about when this fails. All affected builds
have an implicit dependency on the `LLVMgold.so` like this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114229/new/
tbaeder created this revision.
tbaeder added reviewers: MaskRay, fhahn, tejohnson.
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is what the GCC driver does
