[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. In D114320#3154544 , @jessesna wrote: > Thanks a lot for your time and help @MyDeveloperDay No problem, come play some more! We need people to help and review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. Thanks a lot for your time and help @MyDeveloperDay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commits mailing list

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG813d486cbc99: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks (authored by jessesna, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. Great. Thanks a lot. It's Jesses Gott and jesses.gott.na+l...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. one of us can commit it for you but we need to do the following to attribute it to you commit --amend --author="John Doe " So I need your name and email address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. In D114320#3153795 , @MyDeveloperDay wrote: > Thank you for the patch, Do you need help committing this? if so we need your > name and email address to do so > > https://llvm.org/docs/DeveloperPolicy.html#commit-messages

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Thank you for the patch, Do you need help committing this? if so we need your name and email address to do so https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. In D114320#3151741 , @jessesna wrote: > In D114320#3148046 , > @MyDeveloperDay wrote: > >>

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna added a comment. In D114320#3148046 , @MyDeveloperDay wrote: > Ok now I'm a little puzzled, shouldn't this be covered by > `AllowShortIfStatementsOnASingleLine`? That's exactly what i thought when i first stumbled over the behavior :D But I

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Ok now I'm a little puzzled, shouldn't this be covered by `AllowShortIfStatementsOnASingleLine`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

owenpan accepted this revision. owenpan added a comment. Should we add an if-else example to the documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I agree I think this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna updated this revision to Diff 388961. jessesna added a comment. use the more dense "verifyFormat(after,Style)" calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 Files:

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5406 + "{ }", + format("if(a){}else if(b){}else{}", Style), Style); + Style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_Never; you

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna updated this revision to Diff 388924. jessesna added a comment. use verifyFormat instead of EXPECT_EQ (as this does some extra stuff to ensure its stable) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Nothing majorly wrong here, its looks pretty good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commits mailing list

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Could you add the case where the else is not empty. Comment at: clang/unittests/Format/FormatTest.cpp:5400 + Style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_Always; + EXPECT_EQ("if (a)\n" +"{\n" Can

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna created this revision. jessesna added a reviewer: klimek. jessesna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend AllowShortBlocksOnASingleLine for else blocks. See https://bugs.llvm.org/show_bug.cgi?id=49722